Improvement/cldsrv 428 put apis implicit deny#5449
Closed
benzekrimaha wants to merge 6 commits intodevelopment/7.10from
Closed
Improvement/cldsrv 428 put apis implicit deny#5449benzekrimaha wants to merge 6 commits intodevelopment/7.10from
benzekrimaha wants to merge 6 commits intodevelopment/7.10from
Conversation
Contributor
Hello benzekrimaha,My role is to assist you with the merge of this Status report is not available. |
Contributor
Incorrect fix versionThe
Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:
Please check the |
KazToozs
reviewed
Nov 17, 2023
KazToozs
left a comment
KazToozs
left a comment
There was a problem hiding this comment.
Nothing stood out to me that needs particular improvmeent, but a lot of linter changes made this quite a difficult review.
| } | ||
| // if requester is not bucket owner, bucket policy actions should be denied with | ||
| // MethodNotAllowed error | ||
| const onlyOwnerAllowed = ['bucketDeletePolicy', 'bucketGetPolicy', 'bucketPutPolicy']; |
There was a problem hiding this comment.
I'm pretty sure this is not the case anymore and is worth going over
benzekrimaha
force-pushed
the
improvement/CLDSRV-428-put-apis-implicit-Deny
branch
from
430b54c to
4fbe1cd
Compare
benzekrimaha
force-pushed
the
improvement/CLDSRV-428-put-apis-implicit-Deny
branch
from
d8d4982 to
0131eab
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR opened after closing : #5325
Bucket policies are not correctly interpreted, this is part of the following epic to fix that: scality/Arsenal#2181
This PR is aiming to update put apis since object and bucket authorisations are made at API level and need to support implicit denies, ticket linked to this issue here : https://scality.atlassian.net/browse/CLDSRV-428
PRs providing implicit Deny logic to CS for processing in this PR
scality/Arsenal#2181
https://github.com/scality/Vault/pull/2135
#5322
#5420
#5432
I'll be bumping a new CLDSRV once the reviews done as these are changes that will be tested against Integration